Skip to contentSkip to conversation

Change in openvpn[master]: Doxygen: Fix obsolete links to OpenSSL documentation

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Apr 9, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1744193529000.Iabef94b36bae16b2c8288b15b14d660ecb06842d@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/937?usp=email

to review the following change.

Change subject: Doxygen: Fix obsolete links to OpenSSL documentation
......................................................................

Doxygen: Fix obsolete links to OpenSSL documentation

Change-Id Iabef94b36bae16b2c8288b15b14d660ecb06842d

---
M contrib/OCSP_check/OCSP_check.sh
M doc/doxygen/doc_key_generation.h

2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/937/1

contrib/OCSP_check/OCSP_check.sh +1 -1
index e4fec83..ad1a420 100644
@@ -7,7 +7,7 @@
 # OCSP server using the -port option to "openssl ocsp".
 
 # Full documentation and examples:
-# http://www.openssl.org/docs/apps/ocsp.html
+# https://docs.openssl.org/master/man1/openssl-ocsp/#openssl-ocsp
 
 
 # Edit the following values to suit your needs
doc/doxygen/doc_key_generation.h +3 -3
index d32f9d8..91c7a5a 100644
@@ -95,11 +95,11 @@
  * to supply cryptographically strong pseudo-random data.  The following links
  * contain more information on this subject:
  * - For OpenSSL's \c RAND_bytes() function:
- *   http://www.openssl.org/docs/crypto/RAND_bytes.html
+ *   https://docs.openssl.org/master/man3/RAND_bytes/#rand_bytes
  * - For OpenSSL's pseudo-random number generating system:
- *   http://www.openssl.org/docs/crypto/rand.html
+ *   https://docs.openssl.org/master/man7/RAND/#rand
  * - For OpenSSL's support for external crypto modules:
- *   http://www.openssl.org/docs/crypto/engine.html
+ *   https://docs.openssl.org/master/man7/provider/#provider
  *
  * In mbed TLS, the Havege random number generator is used. For details, see
  * the mbed TLS documentation.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/937?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iabef94b36bae16b2c8288b15b14d660ecb06842d
Gerrit-Change-Number: 937
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/937?usp=email )

Change subject: Doxygen: Fix obsolete links to OpenSSL documentation
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
verified that the new links provide relevant content (and the old ones are indeed broken)

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/937?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iabef94b36bae16b2c8288b15b14d660ecb06842d
Gerrit-Change-Number: 937
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Wed, 09 Apr 2025 12:53:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 Doxygen: Fix obsolete links to OpenSSL documentation

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Change-Id Iabef94b36bae16b2c8288b15b14d660ecb06842d

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/937
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

contrib/OCSP_check/OCSP_check.sh +1 -1
index e4fec83..ad1a420 100644
@@ -7,7 +7,7 @@
 # OCSP server using the -port option to "openssl ocsp".
 
 # Full documentation and examples:
-# http://www.openssl.org/docs/apps/ocsp.html
+# https://docs.openssl.org/master/man1/openssl-ocsp/#openssl-ocsp
 
 
 # Edit the following values to suit your needs
doc/doxygen/doc_key_generation.h +3 -3
index d32f9d8..91c7a5a 100644
@@ -95,11 +95,11 @@
  * to supply cryptographically strong pseudo-random data.  The following links
  * contain more information on this subject:
  * - For OpenSSL's \c RAND_bytes() function:
- *   http://www.openssl.org/docs/crypto/RAND_bytes.html
+ *   https://docs.openssl.org/master/man3/RAND_bytes/#rand_bytes
  * - For OpenSSL's pseudo-random number generating system:
- *   http://www.openssl.org/docs/crypto/rand.html
+ *   https://docs.openssl.org/master/man7/RAND/#rand
  * - For OpenSSL's support for external crypto modules:
- *   http://www.openssl.org/docs/crypto/engine.html
+ *   https://docs.openssl.org/master/man7/provider/#provider
  *
  * In mbed TLS, the Havege random number generator is used. For details, see
  * the mbed TLS documentation.
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: Doxygen: Fix obsolete links to OpenSSL documentation

Change looks good, old URLs are broken and new URLs lead to meaningful content. No code change, so nothing to test.

Mail-Archive.org is broken again (seems I get spamfiltered if I send too many patches their way...) so referencing sf.net archive for this.

Your patch has been applied to the master branch.

commit d166fc91c06cfa5c29baed66a2b792db1424c481

Author: Frank Lichtenheld
Date:   Wed Apr 9 14:53:31 2025 +0200
     Doxygen: Fix obsolete links to OpenSSL documentation

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://sourceforge.net/p/openvpn/mailman/message/59171340/
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/937?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: Doxygen: Fix obsolete links to OpenSSL documentation
......................................................................

Doxygen: Fix obsolete links to OpenSSL documentation

Change-Id Iabef94b36bae16b2c8288b15b14d660ecb06842d

Message-Id: <[email protected]...>
URL: https://sourceforge.net/p/openvpn/mailman/message/59171340/

---
M contrib/OCSP_check/OCSP_check.sh
M doc/doxygen/doc_key_generation.h

2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/37/937/2

contrib/OCSP_check/OCSP_check.sh +1 -1
index e4fec83..ad1a420 100644
@@ -7,7 +7,7 @@
 # OCSP server using the -port option to "openssl ocsp".
 
 # Full documentation and examples:
-# http://www.openssl.org/docs/apps/ocsp.html
+# https://docs.openssl.org/master/man1/openssl-ocsp/#openssl-ocsp
 
 
 # Edit the following values to suit your needs
doc/doxygen/doc_key_generation.h +3 -3
index d32f9d8..91c7a5a 100644
@@ -95,11 +95,11 @@
  * to supply cryptographically strong pseudo-random data.  The following links
  * contain more information on this subject:
  * - For OpenSSL's \c RAND_bytes() function:
- *   http://www.openssl.org/docs/crypto/RAND_bytes.html
+ *   https://docs.openssl.org/master/man3/RAND_bytes/#rand_bytes
  * - For OpenSSL's pseudo-random number generating system:
- *   http://www.openssl.org/docs/crypto/rand.html
+ *   https://docs.openssl.org/master/man7/RAND/#rand
  * - For OpenSSL's support for external crypto modules:
- *   http://www.openssl.org/docs/crypto/engine.html
+ *   https://docs.openssl.org/master/man7/provider/#provider
  *
  * In mbed TLS, the Havege random number generator is used. For details, see
  * the mbed TLS documentation.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/937?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iabef94b36bae16b2c8288b15b14d660ecb06842d
Gerrit-Change-Number: 937
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/937?usp=email )

Change subject: Doxygen: Fix obsolete links to OpenSSL documentation
......................................................................

Doxygen: Fix obsolete links to OpenSSL documentation

Change-Id Iabef94b36bae16b2c8288b15b14d660ecb06842d

Message-Id: <[email protected]...>
URL: https://sourceforge.net/p/openvpn/mailman/message/59171340/

---
M contrib/OCSP_check/OCSP_check.sh
M doc/doxygen/doc_key_generation.h

2 files changed, 4 insertions(+), 4 deletions(-)
contrib/OCSP_check/OCSP_check.sh +1 -1
index e4fec83..ad1a420 100644
@@ -7,7 +7,7 @@
 # OCSP server using the -port option to "openssl ocsp".
 
 # Full documentation and examples:
-# http://www.openssl.org/docs/apps/ocsp.html
+# https://docs.openssl.org/master/man1/openssl-ocsp/#openssl-ocsp
 
 
 # Edit the following values to suit your needs
doc/doxygen/doc_key_generation.h +3 -3
index d32f9d8..91c7a5a 100644
@@ -95,11 +95,11 @@
  * to supply cryptographically strong pseudo-random data.  The following links
  * contain more information on this subject:
  * - For OpenSSL's \c RAND_bytes() function:
- *   http://www.openssl.org/docs/crypto/RAND_bytes.html
+ *   https://docs.openssl.org/master/man3/RAND_bytes/#rand_bytes
  * - For OpenSSL's pseudo-random number generating system:
- *   http://www.openssl.org/docs/crypto/rand.html
+ *   https://docs.openssl.org/master/man7/RAND/#rand
  * - For OpenSSL's support for external crypto modules:
- *   http://www.openssl.org/docs/crypto/engine.html
+ *   https://docs.openssl.org/master/man7/provider/#provider
  *
  * In mbed TLS, the Havege random number generator is used. For details, see
  * the mbed TLS documentation.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/937?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iabef94b36bae16b2c8288b15b14d660ecb06842d
Gerrit-Change-Number: 937
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged